Defer closing the opened file when using FileScheme#1668
Merged
spiffcs merged 1 commit intoanchore:mainfrom Mar 15, 2023
Merged
Defer closing the opened file when using FileScheme#1668spiffcs merged 1 commit intoanchore:mainfrom
spiffcs merged 1 commit intoanchore:mainfrom
Conversation
Signed-off-by: razzle <harry@razzle.cloud>
Noxsios
force-pushed
the
defer-file-close-on-source
branch
from
3f0044f to
846c9f7
Compare
spiffcs
approved these changes
Mar 15, 2023
Contributor
|
Thanks for the catch here @Noxsios! |
spiffcs
added a commit
to deitch/syft
that referenced
this pull request
Mar 21, 2023
* main: (47 commits) Deprecate config.yaml as valid config source; Add unit regression for correct config paths (anchore#1640) chore: Update syft bootstrap tools to latest versions. (anchore#1682) Update documentation: (anchore#1680) chore: Update Stereoscope to 7928713c391e20abaede6a029f4ce37b628a4c8b (anchore#1681) fix: reduce logging for bad dpkg lines (anchore#1675) fix ruby classifier (anchore#1678) feat: add shared dir for easier cleanup (anchore#1676) chore(deps): bump github.com/google/go-containerregistry (anchore#1672) chore(deps): bump actions/setup-go from 3 to 4 (anchore#1671) fix: move defer after error to protect panic case (anchore#1670) feat: add argocd, helm, kustomize and kubectl binary classifiers (anchore#1663) defer closing file (anchore#1668) fix: remove author contributing to javascript CPEs (anchore#1669) fix: more python matching support (anchore#1667) Update syft bootstrap tools to latest versions. (anchore#1666) feat: add ruby classifier (anchore#1665) Update syft bootstrap tools to latest versions. (anchore#1658) fix: improved Python binary detection (anchore#1648) fix: suppress some known incorrect vendor candidates for npm CPEs (anchore#1659) fix: sanitize SPDX LicenseRefs (anchore#1657) ... Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
This was referenced Mar 31, 2023
Closed
Merged
5 tasks
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Signed-off-by: razzle <harry@razzle.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On another project - https://github.com/defenseunicorns/zarf , I kept receiving the following error on our Windows build:
This error was thrown attempting to remove files that had been referenced by
source.NewFromFile.I believe the root cause is the dangling file reference in
SetID. Linux/Mac are able to overcome this and can still remove the file, but Windows cannot.